vanzin commented on a change in pull request #23156: [SPARK-24063][SS] Add
maximum epoch queue threshold for ContinuousExecution
URL: https://github.com/apache/spark/pull/23156#discussion_r259140188
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/EpochCoordinatorSuite.scala
##########
@@ -186,6 +192,74 @@ class EpochCoordinatorSuite
verifyCommitsInOrderOf(List(1, 2, 3, 4, 5))
}
+ test("several epochs, max epoch backlog reached by partitionOffsets") {
+
Review comment:
nit: there's a bunch of empty lines in these tests for so little code; that
makes it weird to read the code.
```
doSomething()
* brain pauses when it sees empty lines *
doSomething()
* another brain pause *
etc etc
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
