asmello commented on issue #23882: [SPARK-26979][PySpark][WIP] Add missing column name support for some SQL functions URL: https://github.com/apache/spark/pull/23882#issuecomment-466780589 @srowen I edited the description to make this more clear. The patch **adds** support for column names as arguments to those functions. The function mechanism was removed in those instances because it provided no support for this, so those functions had to be explicitly defined instead. The ones I've seen declared twice were `lower()`, `upper()` and `initcap()`. Since the second definition of `initcap()` was explicit and better documented, I only removed the implicit instance in that case, but otherwise I replaced both implicit definitions with a new explicit one. The function mechanism is very dangerous for allowing this. Is there a good reason for it to be there at all?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
