asmello commented on issue #23882: [SPARK-26979][PySpark][WIP] Add missing column name support for some SQL functions URL: https://github.com/apache/spark/pull/23882#issuecomment-466802265 > I think it's OK to focus here on fixing the duplicated definition, and the small change to `_create_function` that lets it work consistently with other similar Pyspark methods. Ok, I will change this PR so that we turn `lit()`, `col()`, `column()`, `asc()` and `desc()` into explicit forms instead of the string/binary functions and `abs()`. I will also double check if the `_create_function` change affects anything else. > found `sampleBy` which supports string or Column, but `approxQuantile` which doesn't seem to. Thanks for looking into this, I haven't had the time. I will also update the PR to include a change there so that it supports Column objects too. When I have time I will also look for other cases like this, but it might take me a day or two before I can work on these changes at all.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
