asmello commented on issue #23882: [SPARK-26979][PySpark][WIP] Add missing column name support for some SQL functions URL: https://github.com/apache/spark/pull/23882#issuecomment-466786065 > I agree this method of declaring can be error-prone; I fixed another one recently. It's there to avoid repeating a bunch of code. I don't think it's so bad or worth changing here. I can see the reasoning for the mechanism, but since this duplication happened several times already maybe it would be worth it adding tests for this? I don't think the explicit approach is much worse anyway, specially if better (multiline, with examples) documentation is added. I'm not particularly bothered by this, but I also can see it causing more problems in the future. > If `_create_function` made use of `_to_java_column`, would this be resolved for all these functions without breaking them out? I think so, except we then have to break out `lit()`, `col()`, `column()`, `asc()` and `desc()`...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
