dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL]
Extends Analyze commands for cached tables
URL: https://github.com/apache/spark/pull/24047#discussion_r264521442
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala
##########
@@ -181,6 +182,38 @@ class CacheManager extends Logging {
}
}
+ private[sql] def analyzeColumnCacheQuery(
+ query: Dataset[_],
+ columnNames: Seq[Attribute]): Unit = writeLock {
Review comment:
`columnNames` -> `columns` because it becomes `Seq[Attribute]` instead of
`Seq[String]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
