dongjoon-hyun commented on a change in pull request #24047: [SPARK-25196][SQL]
Extends Analyze commands for cached tables
URL: https://github.com/apache/spark/pull/24047#discussion_r264523890
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
##########
@@ -89,6 +89,37 @@ case class AnalyzeColumnCommand(
columnsToAnalyze
}
+ private def analyzeColumnInCatalog(sparkSession: SparkSession): Unit = {
+ val sessionState = sparkSession.sessionState
+ val db =
tableIdent.database.getOrElse(sessionState.catalog.getCurrentDatabase)
+ val tableIdentWithDB = TableIdentifier(tableIdent.table, Some(db))
Review comment:
Since `getTableMetadata` and `alterTableStats` already have the above logic,
shall we remove the above two redundant lines?
```scala
- val db =
tableIdent.database.getOrElse(sessionState.catalog.getCurrentDatabase)
- val tableIdentWithDB = TableIdentifier(tableIdent.table, Some(db))
- val tableMeta = sessionState.catalog.getTableMetadata(tableIdentWithDB)
+ val tableMeta = sessionState.catalog.getTableMetadata(tableIdent)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
