Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3737#issuecomment-67567871
I think that the main risk of this patch is that boto has deprecated /
removed / changed functionality that we rely on, but that we won't notice this
until users run commands that exercise those branches (yay dynamic languages!).
I was able to launch a basic spot cluster, so I think that we should be in
pretty good shape. I could try running a code coverage tool on this while I
launch the cluster to see if there are any branches that I've missed, then just
look through the Boto docs to see whether that functionality's still present.
OTOH, if Boto is good about maintaining backwards compatibility, then I
guess it's probably fine to merge this and wait to see if we hit problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
