Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/3737#issuecomment-67613960
Nice work, Josh.
I took a quick look at the coverage report. It looks like most of it is
covered. If we want to be extra thorough, I think there are a few more things
relevant to boto that were not hit. (Or perhaps you hit them but they were not
captured in this particular report file.)
*
[L353](https://gist.github.com/JoshRosen/c09a742805bae3503185#file-spark_ec2-py-cover-L353)
- launching into a VPC
*
[L430](https://gist.github.com/JoshRosen/c09a742805bae3503185#file-spark_ec2-py-cover-L430),
[L439](https://gist.github.com/JoshRosen/c09a742805bae3503185#file-spark_ec2-py-cover-L439)
- stuff related to EBS volumes and block mapping
*
[L507](https://gist.github.com/JoshRosen/c09a742805bae3503185#file-spark_ec2-py-cover-L507)
- regular launch
*
[L531](https://gist.github.com/JoshRosen/c09a742805bae3503185#file-spark_ec2-py-cover-L531)
- resume interrupted launch
By the way, I noticed some unused (and unreachable) code at
[L653](https://gist.github.com/JoshRosen/c09a742805bae3503185#file-spark_ec2-py-cover-L653).
We can probably delete it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
