MaxGekk commented on a change in pull request #20793:
[SPARK-23643][CORE][SQL][ML] Shrinking the buffer in hashSeed up to size of the
seed parameter
URL: https://github.com/apache/spark/pull/20793#discussion_r266471710
##########
File path: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala
##########
@@ -739,7 +739,7 @@ class PairRDDFunctionsSuite extends SparkFunSuite with
SharedSparkContext {
val dist = new BinomialDistribution(trials, p)
val q = dist.cumulativeProbability(actual)
withClue(s"p = $p: trials = $trials") {
- assert(q >= 0.001 && q <= 0.999)
+ assert(q >= 0.001 && q < 0.99999)
Review comment:
Otherwise the assert fails with:
```
p = 0.1: trials = 30 0.9995456448850946 was greater than or equal to 0.001,
but 0.9995456448850946 was not less than or equal to 0.999
```
I will change the assert to `assert(0.0 <= q && q <= 1.0)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
