MaxGekk commented on a change in pull request #20793: [SPARK-23643][CORE][SQL][ML] Shrinking the buffer in hashSeed up to size of the seed parameter URL: https://github.com/apache/spark/pull/20793#discussion_r267211798
########## File path: mllib/src/test/scala/org/apache/spark/ml/clustering/PowerIterationClusteringSuite.scala ########## @@ -35,7 +35,7 @@ class PowerIterationClusteringSuite extends SparkFunSuite @transient var data: Dataset[_] = _ final val r1 = 1.0 final val n1 = 10 - final val r2 = 4.0 + final val r2 = 100.0 Review comment: > but was this the change you were discussing with the author of the recent change to the PIC tests? We just agreed there is a problem in PIC (in random mode at least). From my understanding, what I can do there is: - open a JIRA ticket, and wait when PIC will be fixed (close the PR or postpone it). - tune the test. Actually there are no so much sticks I can play with in the test. This is minimal changes I have found so far. - Ignore the PIC test for random mode, and open a ticket to fix it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
