MaxGekk commented on a change in pull request #20793: [SPARK-23643][CORE][SQL][ML] Shrinking the buffer in hashSeed up to size of the seed parameter URL: https://github.com/apache/spark/pull/20793#discussion_r267213741
########## File path: mllib/src/test/scala/org/apache/spark/ml/clustering/PowerIterationClusteringSuite.scala ########## @@ -35,7 +35,7 @@ class PowerIterationClusteringSuite extends SparkFunSuite @transient var data: Dataset[_] = _ final val r1 = 1.0 final val n1 = 10 - final val r2 = 4.0 + final val r2 = 100.0 Review comment: Just in case, in the master (without the changes) if I set `r2` to `3.0`, the test `power iteration clustering` fails too. Is there a theoretical foundation for 4.0 there. It seems `4.0` for `r2` was selected to pass the test only. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
