cloud-fan commented on a change in pull request #24129: [SPARK-27190][SQL] add
table capability for streaming
URL: https://github.com/apache/spark/pull/24129#discussion_r266711897
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
##########
@@ -353,13 +354,15 @@ private[kafka010] class KafkaSourceProvider extends
DataSourceRegister
}
class KafkaTable(strategy: => ConsumerStrategy) extends Table
- with SupportsMicroBatchRead with SupportsContinuousRead with
SupportsStreamingWrite {
+ with SupportsRead with SupportsWrite {
Review comment:
I raised the same concern before. @rdblue shall we reconsider it? I don't
think we need the flexibility to change the read/write API(it will be a
breaking change anyway). It's more important to make the API consistent with
itself, and only has a single capability API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
