MaxGekk commented on a change in pull request #20793:
[SPARK-23643][CORE][SQL][ML] Shrinking the buffer in hashSeed up to size of the
seed parameter
URL: https://github.com/apache/spark/pull/20793#discussion_r267964394
##########
File path: R/pkg/tests/fulltests/test_mllib_classification.R
##########
@@ -299,21 +299,21 @@ test_that("spark.mlp", {
df <-
read.df(absoluteSparkPath("data/mllib/sample_multiclass_classification_data.txt"),
source = "libsvm")
model <- spark.mlp(df, label ~ features, blockSize = 128, layers = c(4, 5,
4, 3),
- solver = "l-bfgs", maxIter = 100, tol = 0.5, stepSize =
1, seed = 1)
+ solver = "l-bfgs", maxIter = 100, tol = 0.5, stepSize =
1, seed = 42)
# Test summary method
summary <- summary(model)
expect_equal(summary$numOfInputs, 4)
expect_equal(summary$numOfOutputs, 3)
expect_equal(summary$layers, c(4, 5, 4, 3))
expect_equal(length(summary$weights), 64)
- expect_equal(head(summary$weights, 5), list(-0.878743, 0.2154151, -1.16304,
-0.6583214, 1.009825),
+ expect_equal(head(summary$weights, 5), list(0.2664868, 0.02332, 0.8180507,
-0.5645642, 0.4120664),
Review comment:
the values are significantly different because I changed seed. I will revert
it back
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
