Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3737#issuecomment-67661702
I think a few of the skipped lines themselves are okay, since
[L354](https://gist.github.com/JoshRosen/c09a742805bae3503185#file-spark_ec2-py-cover-L353),
is similar to some calls right below it that were actually run. On the other
hand, the fact that we didn't run the VPC code path means that we didn't end up
calling `run` with the VPC arguments, so it's still possible that those could
error out.
This is one of those cases where line coverage is kind of a minimum
standard but not the end-all of coverage metrics, since it doesn't capture the
space of different configurations / arguments that we call Boto with.
Since I've got to launch a cluster anyways, I'll try spinning up one more
in a VPC just to be safe.
Good call on the `setup_standalone_cluster` code, by the way; it looks
unused, so I'll remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
