Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3705#issuecomment-67900715
> Note 1: Unit testing this is hard (if even possible), since local-cluster
mode doesn't seem to leave the Master/Worker daemons running long enough after
sc.stop() is called for the clean up protocol to take effect.
I have a testing framework that can reliably test these sorts of scenarios;
I'm planning to open-source it once I've cleaned up and reorganized its code.
> Note 2: the code tracking finished apps / app directories in Master.scala
and Worker.scala is not really thread-safe, but then the code that modifies
other shared maps in those classes isn't either, so this change is not making
anything worse.
Yeah, the code there is due for a thread-safety audit / cleanup. A lot of
the fields in those files have unnecessarily broad visibility, in many cases
because they're read in the web UI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
