Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3705#issuecomment-67907467
> re: thread-safety, the code I added could definitely be triggered from
different actors, so I added some synchronization
Do you mean the `maybeCleanupApplication` method? It looks like it's only
called from two places, both message-handlers in `receiveWithLogging` (which is
synchronized by Akka). Similarly, `appDirectories` is only accessed in
`receiveWithLogging` and `maybeCleanupApplication`, so I think all accesses to
that field will be serialized by Akka.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
