Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3705#discussion_r22195734
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala 
---
    @@ -452,6 +469,19 @@ private[spark] class Worker(
         registerWithMaster()
       }
     
    +  private def maybeCleanupApplication(id: String): Unit = synchronized {
    +    val shouldCleanup = finishedApps.contains(id) && 
!executors.values.exists(_.appId == id)
    +    if (shouldCleanup) {
    +      finishedApps -= id
    +      appDirectories.remove(id).foreach {
    +        logInfo(s"Cleaning up local directories for application $id")
    +        _.foreach { dir =>
    --- End diff --
    
    Minor nit, but I think it would be clearer to introduce an `appDirectory` 
variable in the outer `foreach` rather than using the underscore here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to