rezasafi commented on a change in pull request #23767: [SPARK-26329][CORE]
Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r270237846
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -191,9 +191,20 @@ private[spark] class Executor(
*/
private val HEARTBEAT_INTERVAL_MS = conf.get(EXECUTOR_HEARTBEAT_INTERVAL)
+ /**
+ * Interval to poll for executor metrics, in milliseconds
+ */
+ private val METRICS_POLLING_INTERVAL_MS =
conf.get(EXECUTOR_METRICS_POLLING_INTERVAL)
Review comment:
seems that we have a config for logging executor metrics that before was
basedon heartbeat, now your change is adding another config to have the metrics
based on a new interval. That's sound like a lot of redundant metrics. Maybe we
want to simplify configs and remove the previous one and then default this one
to heartbeat for simplification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
