rezasafi commented on a change in pull request #23767: [SPARK-26329][CORE]
Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r270536151
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -191,9 +191,20 @@ private[spark] class Executor(
*/
private val HEARTBEAT_INTERVAL_MS = conf.get(EXECUTOR_HEARTBEAT_INTERVAL)
+ /**
+ * Interval to poll for executor metrics, in milliseconds
+ */
+ private val METRICS_POLLING_INTERVAL_MS =
conf.get(EXECUTOR_METRICS_POLLING_INTERVAL)
Review comment:
3 is still in use of 1 and 2 and if somebody don't want to use 4 they will
need to tune 3.
And it was bad that we didn't document the relation between (2) and (1).
If you like you can comment it some where at least that for this change the
user need to set both (1) and (4). This is to avoid users file issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
