rezasafi commented on a change in pull request #23767: [SPARK-26329][CORE]
Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r270419965
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -191,9 +191,20 @@ private[spark] class Executor(
*/
private val HEARTBEAT_INTERVAL_MS = conf.get(EXECUTOR_HEARTBEAT_INTERVAL)
+ /**
+ * Interval to poll for executor metrics, in milliseconds
+ */
+ private val METRICS_POLLING_INTERVAL_MS =
conf.get(EXECUTOR_METRICS_POLLING_INTERVAL)
Review comment:
After your change being merged for someone to get executor metrics they need
to consider 4 configs. 1) spark.eventLog.logStageExecutorMetrics.enabled
2)"spark.eventLog.logStageExecutorProcessTreeMetrics.enabled"
3)"spark.executor.heartbeatInterval" 4)"spark.executor.metrics.pollingInterval"
Number 2 is totally different and we can't consolidate. However I feel like
we can say that whenever number 4 is set then user definitely want number one
too. So They don't need to set both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
