srowen commented on a change in pull request #24270:
[SPARK-27343][KAFKA][SS]Avoid hadcoded for spark-sql-kafka-0-10
URL: https://github.com/apache/spark/pull/24270#discussion_r271314011
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala
##########
@@ -523,7 +523,7 @@ private[kafka010] object KafkaDataConsumer extends Logging
{
// tasks simultaneously using consumers than the capacity.
private lazy val cache = {
val conf = SparkEnv.get.conf
- val capacity = conf.getInt("spark.sql.kafkaConsumerCache.capacity", 64)
+ val capacity = conf.getInt(CONSUMER_CACHE_CAPACITY.key, 64)
Review comment:
Same comment about not needing to repeat a default here. Same for others
below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
