srowen commented on a change in pull request #24270:
[SPARK-27343][KAFKA][SS]Avoid hadcoded for spark-sql-kafka-0-10
URL: https://github.com/apache/spark/pull/24270#discussion_r271313906
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousStream.scala
##########
@@ -53,7 +53,7 @@ class KafkaContinuousStream(
failOnDataLoss: Boolean)
extends ContinuousStream with Logging {
- private val pollTimeoutMs =
sourceOptions.getOrElse("kafkaConsumer.pollTimeoutMs", "512").toLong
+ private val pollTimeoutMs =
sourceOptions.getOrElse(CONSUMER_POLL_TIMEOUT.key, "512").toLong
Review comment:
These options that don't begin with "spark." and aren't from the Spark
config shouldn't use the Spark config mechanism. Same for others below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
