srowen commented on a change in pull request #24270:
[SPARK-27343][KAFKA][SS]Avoid hadcoded for spark-sql-kafka-0-10
URL: https://github.com/apache/spark/pull/24270#discussion_r271314833
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
##########
@@ -456,11 +456,15 @@ private[kafka010] class KafkaSourceProvider extends
DataSourceRegister
}
private[kafka010] object KafkaSourceProvider extends Logging {
- private val STRATEGY_OPTION_KEYS = Set("subscribe", "subscribepattern",
"assign")
+ private val STRATEGY_OPTION_KEYS = Set(SUBSCRIBE, SUBSCRIBEPATTERN, ASSIGN)
+ private val ASSIGN = "assign"
Review comment:
I don't think constants like this add much value. They'll never change, and
they don't add to readability, and add a level of indirection. They do maybe
avoid typos. I am not sure it's worth it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
