tgravescs commented on a change in pull request #24374: [SPARK-27366][CORE] Support GPU Resources in Spark job scheduling URL: https://github.com/apache/spark/pull/24374#discussion_r275814791
########## File path: core/src/main/scala/org/apache/spark/ResourceInformation.scala ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark + +import org.apache.spark.annotation.Evolving + +/** + * Class to hold information about a type of Resource. A resource could be a gpu, fpga, numa, etc. + * The array of addresses are resource specific and describe how to access the resource. + * For instance, for gpus the addresses would be the indices of the gpus. + * + * @param name the name of the resource + * @param units the units of the resources, can be an empty string if units don't apply Review comment: the example script provided is just doing gpu's and units don't apply to gpu's so its just finding the addresses. I agree with you that we need some more docs and I'll comment the script better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
