tgravescs commented on a change in pull request #24374: [SPARK-27366][CORE] 
Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r275847898
 
 

 ##########
 File path: examples/src/main/resources/getGpuResources.sh
 ##########
 @@ -0,0 +1,2 @@
++# This script uses nvidia-smi command so only works with nvidia GPUs. This is 
a very basic script that lists the index's of the available GPU's where the 
executor was allocated.
 
 Review comment:
   the script as is will find all GPU's visible to it, so if the cluster 
manager doesn't isolate it will find all on the host.  Standalone mode, I would 
expect to use the --gpuDevices parameter to the Executor.    It would be good 
to add a warning in the config description and here about that, or say the 
config isnt' supported in standalone mode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to