tgravescs commented on a change in pull request #24374: [SPARK-27366][CORE]
Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r275830252
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -371,6 +374,11 @@ class SparkContext(config: SparkConf) extends Logging {
throw new SparkException("An application name must be set in your
configuration")
}
+ _resources = conf.get(DRIVER_GPU_ADDRESSES).map(ids => {
Review comment:
yes gpu's on the driver, I think the main use case is standalone mode or if
someone doesn't have isolation. They can't just look on the host and take all
the gpu's as they should only use the ones the cluster manager assigned to
them.
Yes it will be by convention but its better thenwhat we have now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
