cloud-fan commented on a change in pull request #24570: [SPARK-24923][SQL]
Implement v2 CreateTableAsSelect
URL: https://github.com/apache/spark/pull/24570#discussion_r283234683
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
##########
@@ -46,14 +57,22 @@ case class DataSourceResolution(conf: SQLConf) extends
Rule[LogicalPlan] with Ca
CreateTable(tableDesc, mode, None)
case CreateTableAsSelectStatement(
- table, query, partitionCols, bucketSpec, properties,
V1WriteProvider(provider), options,
- location, comment, ifNotExists) =>
+ AsTableIdentifier(table), query, partitionCols, bucketSpec, properties,
+ V1WriteProvider(provider), options, location, comment, ifNotExists) =>
val tableDesc = buildCatalogTable(table, new StructType, partitionCols,
bucketSpec,
properties, provider, options, location, comment, ifNotExists)
val mode = if (ifNotExists) SaveMode.Ignore else SaveMode.ErrorIfExists
CreateTable(tableDesc, mode, Some(query))
+
+ case create: CreateTableAsSelectStatement =>
+ // the provider was not a v1 source, convert to a v2 plan
+ val CatalogObjectIdentifier(maybeCatalog, identifier) = create.tableName
+ val catalog = maybeCatalog.orElse(defaultCatalog)
Review comment:
The ability to change the default catalog can be done later. I'd like to add
it when we migrate hive catalog to `TableCatalog` API, so that the default can
be hive catalog.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
