cloud-fan commented on a change in pull request #24570: [SPARK-24923][SQL]
Implement v2 CreateTableAsSelect
URL: https://github.com/apache/spark/pull/24570#discussion_r283634702
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
##########
@@ -112,4 +129,41 @@ case class DataSourceResolution(conf: SQLConf) extends
Rule[LogicalPlan] with Ca
properties = properties,
comment = comment)
}
+
+ private def convertCTAS(
+ catalog: TableCatalog,
+ identifier: Identifier,
+ ctas: CreateTableAsSelectStatement): CreateTableAsSelect = {
+ if (ctas.options.contains("path") && ctas.location.isDefined) {
+ throw new AnalysisException(
+ "LOCATION and 'path' in OPTIONS are both used to indicate the custom
table path, " +
Review comment:
and shall we do the same check for `provider` and `comment`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
