cloud-fan commented on a change in pull request #24570: [SPARK-24923][SQL]
Implement v2 CreateTableAsSelect
URL: https://github.com/apache/spark/pull/24570#discussion_r283634338
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
##########
@@ -112,4 +129,41 @@ case class DataSourceResolution(conf: SQLConf) extends
Rule[LogicalPlan] with Ca
properties = properties,
comment = comment)
}
+
+ private def convertCTAS(
+ catalog: TableCatalog,
+ identifier: Identifier,
+ ctas: CreateTableAsSelectStatement): CreateTableAsSelect = {
+ if (ctas.options.contains("path") && ctas.location.isDefined) {
+ throw new AnalysisException(
+ "LOCATION and 'path' in OPTIONS are both used to indicate the custom
table path, " +
+ "you can only specify one of them.")
+ }
+
+ val options = ctas.options.filterKeys(_ != "path")
+
+ // convert the bucket spec and add it as a transform
+ val partitioning = ctas.partitioning ++ ctas.bucketSpec.map(_.asTransform)
+
+ // create table properties from TBLPROPERTIES and OPTIONS clauses
+ val properties = new mutable.HashMap[String, String]()
+ properties ++= ctas.properties
+ properties ++= options
+
+ // convert USING, LOCATION, and COMMENT clauses to table properties
+ properties += ("provider" -> ctas.provider)
+ ctas.comment.map(text => properties += ("comment" -> text))
Review comment:
This is a good point. When saving Spark tables to Hive metastore, we need to
store some spark specific information in the table properties. And we always
use `spark.sql.` as the prefix for the property keys.
~Shall we follow it and add a prefix here as well?~
EDIT:
Since data source implementations need to know these properties, shall we
just document these special properties?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
