dongjoon-hyun commented on a change in pull request #24719: [SPARK-27849][SQL]
Redact treeString of FileTable and DataSourceV2ScanExecBase
URL: https://github.com/apache/spark/pull/24719#discussion_r288411021
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileDataSourceV2.scala
##########
@@ -49,6 +51,13 @@ trait FileDataSourceV2 extends TableProvider with
DataSourceRegister {
}
protected def getTableName(paths: Seq[String]): String = {
- shortName() + ":" + paths.mkString(";")
+ val name = shortName().capitalize + " " +
paths.map(qualifiedPathName).mkString(",")
Review comment:
`shortName().capitalize` looks like beyond the initial goal(`redact`) of
this PR. Is this capitalization is required to pass the tests? Otherwise, shall
we keep the existing behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
