dongjoon-hyun commented on a change in pull request #24719: [SPARK-27849][SQL]
Redact treeString of FileTable and DataSourceV2ScanExecBase
URL: https://github.com/apache/spark/pull/24719#discussion_r288415208
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/DataSourceScanExecRedactionSuite.scala
##########
@@ -53,18 +62,21 @@ class DataSourceScanExecRedactionSuite extends QueryTest
with SharedSQLContext {
assert(df.queryExecution.simpleString.contains(replacement))
}
}
+}
- private def isIncluded(queryExecution: QueryExecution, msg: String): Boolean
= {
- queryExecution.toString.contains(msg) ||
- queryExecution.simpleString.contains(msg) ||
- queryExecution.stringWithStats.contains(msg)
- }
Review comment:
Could you add a document like
https://github.com/apache/spark/pull/24719/files#diff-0c515221ed6e6eadcec71b3b9ad3a3e1R116
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
