dongjoon-hyun commented on a change in pull request #24719: [SPARK-27849][SQL]
Redact treeString of FileTable and DataSourceV2ScanExecBase
URL: https://github.com/apache/spark/pull/24719#discussion_r288414881
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/DataSourceScanExecRedactionSuite.scala
##########
@@ -19,26 +19,35 @@ package org.apache.spark.sql.execution
import org.apache.hadoop.fs.Path
import org.apache.spark.SparkConf
-import org.apache.spark.sql.QueryTest
+import org.apache.spark.sql.{DataFrame, QueryTest}
+import org.apache.spark.sql.execution.datasources.v2.BatchScanExec
+import org.apache.spark.sql.execution.datasources.v2.orc.OrcScan
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.test.SharedSQLContext
/**
* Suite that tests the redaction of DataSourceScanExec
*/
-class DataSourceScanExecRedactionSuite extends QueryTest with SharedSQLContext
{
+abstract class DataSourceScanRedactionTest extends QueryTest with
SharedSQLContext {
override protected def sparkConf: SparkConf = super.sparkConf
- .set("spark.redaction.string.regex", "file:/[\\w_]+")
+ .set("spark.redaction.string.regex", "file:/[\\w_/]+")
Review comment:
It looks correct fix, but do we need to change the pattern to pass the tests
by adding '/'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
