squito commented on a change in pull request #24817: [WIP][SPARK-27963][core]
Allow dynamic allocation without a shuffle service.
URL: https://github.com/apache/spark/pull/24817#discussion_r296401733
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
##########
@@ -279,5 +452,35 @@ private[spark] class ExecutorMonitor(
updateNextTimeout(newDeadline)
}
}
+
+ def addShuffle(id: Int): Unit = {
+ if (shuffleIds.add(id)) {
+ hasActiveShuffle = true
+ if (!isIdle) {
+ updateTimeout()
Review comment:
`isIdle` is always false here, because you've just set
`hasActiveShuffle=true`, right? I guess I am not sure why you'd need to call
updateTimeout() here so I'm not sure the right condition to check ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
