squito commented on a change in pull request #24817: [WIP][SPARK-27963][core]
Allow dynamic allocation without a shuffle service.
URL: https://github.com/apache/spark/pull/24817#discussion_r296402456
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
##########
@@ -201,6 +332,25 @@ private[spark] class ExecutorMonitor(
}
}
+ override def onOtherEvent(event: SparkListenerEvent): Unit = event match {
+ case ShuffleCleanedEvent(id) => cleanupShuffle(id)
+ case _ =>
+ }
+
+ override def rddCleaned(rddId: Int): Unit = { }
+
+ override def shuffleCleaned(shuffleId: Int): Unit = {
+ // Because this is called in a completely separate thread, we post a
custom event to the
+ // listener bus so that the internal state is safely updated.
+ listenerBus.post(ShuffleCleanedEvent(shuffleId))
Review comment:
it is weird that this will be visible to all user listeners as well ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
