squito commented on a change in pull request #24817: [WIP][SPARK-27963][core]
Allow dynamic allocation without a shuffle service.
URL: https://github.com/apache/spark/pull/24817#discussion_r296399405
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
##########
@@ -124,6 +149,98 @@ private[spark] class ExecutorMonitor(
def pendingRemovalCount: Int = executors.asScala.count { case (_, exec) =>
exec.pendingRemoval }
+ override def onJobStart(event: SparkListenerJobStart): Unit = {
+ if (!shuffleTrackingEnabled) {
+ return
+ }
+
+ val shuffleStages = event.stageInfos.flatMap { s =>
+ s.shuffleDepId.toSeq.map { shuffleId =>
+ s.stageId -> shuffleId
+ }
+ }
+
+ var updateExecutors = false
+ shuffleStages.foreach { case (sid, shuffle) =>
Review comment:
nit: can you rename `sid` -> `stageId`? `sid` sounds like it could also be
`shuffleId`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
