Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3629#issuecomment-69423665
Also, the other issue with this patch is that `unrollSafely` is not used
exclusively with `tryToPut`; it is also used in
`CacheManager#putInBlockManager`. If we acquire pending memory in
`unrollSafely` and expect `tryToPut` to release it later, then we will never
release the pending memory in the `CacheManager` case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
