Github user suyanNone commented on the pull request:
https://github.com/apache/spark/pull/3629#issuecomment-70203787
@andrewor14
I will still releasePendingUnrollMemory() before [this
line](https://github.com/apache/spark/blob/4e1f12d997426560226648d62ee17c90352613e7/core/src/main/scala/org/apache/spark/storage/MemoryStore.scala#L331)
because, if release after `ensureFreeSpace`, it will also make a double
count.
```
val actualFreeMemory = freeMemory - currentUnrollMemory
```
because `memoryStore.tryToPut` will got a `accountingLock.{ }`, so this
will make sure no others will use that `pendingUnrollMemory`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
