Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3629#issuecomment-69653790
> after unroll, may the block can put in memoryStore, it will return a
unrolled data(array), and then call blockManager.putArray, it will finally to
call memoryStore.tryToPut, because we call unrollSafelly in CacheManager only
if the block level have memory_level.
I see, but this basically assumes that `tryToPut` will always be called
after `unrollSafely` if we return an array there, and the code right now has no
such guarantees event though this does happen to be the case currently. If we
want to enforce this guarantee we must document it explicitly in the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
