xuanyuanking commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r299322442
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -2710,7 +2710,67 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with TimeLi
assert(countSubmittedMapStageAttempts() === 2)
}
- test("SPARK-23207: retry all the succeeding stages when the map stage is
indeterminate") {
+ test("SPARK-25341: abort stage while using old fetch protocol") {
+ // reset the test context with using old fetch protocol
+ afterEach()
Review comment:
```
It should already be called when the previous test is finished and right
before running this test.
```
Yeah, that's right but we still need to call this because the spark context
is created in `beforeEach`, here we call `afterEach` is to stop the context
which starts by the latest `beforeEach`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
