xuanyuanking commented on a change in pull request #24892: [SPARK-25341][Core] 
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r299322818
 
 

 ##########
 File path: 
core/src/test/scala/org/apache/spark/shuffle/sort/IndexShuffleBlockResolverSuite.scala
 ##########
 @@ -155,4 +156,19 @@ class IndexShuffleBlockResolverSuite extends 
SparkFunSuite with BeforeAndAfterEa
       indexIn2.close()
     }
   }
+
+  test("commit shuffle files multiple times") {
+    val shuffleId = 1
+    val mapId = 2
+    val idxName = s"shuffle_${shuffleId}_${mapId}_0.index"
+    testWithIndexShuffleBlockResolver(shuffleId, mapId, idxName, -1)
+  }
+
+  test("commit shuffle files with shuffle generation id multiple times") {
 
 Review comment:
   Thanks for the advice, add a new case in 
IndexShuffleBlockResolverSuite.scala. Done in 3ec15dc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to