rdblue commented on a change in pull request #24832: [SPARK-27845][SQL]
DataSourceV2: InsertTable
URL: https://github.com/apache/spark/pull/24832#discussion_r300790364
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -593,4 +594,61 @@ class DDLParserSuite extends AnalysisTest {
Seq(Seq("x"), Seq("y"), Seq("a", "b", "c"))))
}
}
+
+ test("insert table: append") {
+ parseCompare("INSERT INTO TABLE testcat.ns1.ns2.tbl TABLE source",
+ table("source").insertInto(table("testcat", "ns1", "ns2", "tbl")))
Review comment:
I would prefer to see parser tests written using the expected case classes
instead of calling factory methods. I don't know what the guarantees of these
factory methods are, and using the plan nodes directly avoids relying on
default values from those factory methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
