rdblue commented on a change in pull request #24832: [SPARK-27845][SQL]
DataSourceV2: InsertTable
URL: https://github.com/apache/spark/pull/24832#discussion_r300794292
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala
##########
@@ -344,4 +345,113 @@ class DataSourceV2SQLSuite extends QueryTest with
SharedSQLContext with BeforeAn
df_joined)
}
}
+
+ test("InsertTable: append") {
+ val t1 = "testcat.ns1.ns2.tbl"
+ withTable(t1) {
+ sql(s"CREATE TABLE $t1 (id bigint, data string) USING foo")
+ sql(s"INSERT INTO $t1 SELECT id, data FROM source")
+ checkAnswer(spark.table(t1), spark.table("source"))
+ }
+ }
+
+ test("InsertTable: append - across catalog") {
+ val t1 = "testcat.ns1.ns2.tbl"
+ val t2 = "testcat2.db.tbl"
+ withTable(t1, t2) {
+ sql(s"CREATE TABLE $t1 USING foo AS TABLE source")
+ sql(s"CREATE TABLE $t2 (id bigint, data string) USING foo")
+ sql(s"INSERT INTO $t2 SELECT * FROM $t1")
+ checkAnswer(spark.table(t2), spark.table("source"))
+ }
+ }
+
+ test("InsertTable: append partitioned table - dynamic clause") {
+ val t1 = "testcat.ns1.ns2.tbl"
+ withTable(t1) {
+ sql(s"CREATE TABLE $t1 (id bigint, data string) USING foo PARTITIONED BY
(id)")
+ sql(s"INSERT INTO TABLE $t1 TABLE source")
+ checkAnswer(spark.table(t1), spark.table("source"))
+ }
+ }
+
+ test("InsertTable: append partitioned table - static clause") {
+ val t1 = "testcat.ns1.ns2.tbl"
+ withTable(t1) {
+ sql(s"CREATE TABLE $t1 (id bigint, data string) USING foo PARTITIONED BY
(id)")
+ sql(s"INSERT INTO $t1 PARTITION (id = 23) SELECT data FROM source")
+ checkAnswer(spark.table(t1), sql("SELECT 23, data FROM source"))
+ }
+ }
+
+ test("InsertTable: overwrite non-partitioned table") {
+ val t1 = "testcat.ns1.ns2.tbl"
+ withTable(t1) {
+ sql(s"CREATE TABLE $t1 USING foo AS TABLE source")
Review comment:
I'd prefer to avoid using `CREATE ... AS TABLE source` as a select
statement. While it is valid, I don't think it is very clear what is happening.
It better for readability in these tests to use `CREATE ... AS SELECT ... FROM
source`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
