rdblue commented on a change in pull request #24832: [SPARK-27845][SQL]
DataSourceV2: InsertTable
URL: https://github.com/apache/spark/pull/24832#discussion_r300795351
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala
##########
@@ -344,4 +345,113 @@ class DataSourceV2SQLSuite extends QueryTest with
SharedSQLContext with BeforeAn
df_joined)
}
}
+
+ test("InsertTable: append") {
Review comment:
This needs more tests for negative cases as well. It should verify that
additional columns, missing columns, etc. are caught by `ResolveOutputRelation`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
