huaxingao commented on issue #25046: [SPARK-28243][PYSPARK][ML] Remove setFeatureSubsetStrategy and setSubsamplingRate from Python TreeEnsembleParams URL: https://github.com/apache/spark/pull/25046#issuecomment-513020251 I made modifications in python to match the changes in https://github.com/apache/spark/commit/4aa9ccbde7870fb2750712e9e38e6aad740e0770#diff-6b8a041f558af2b7bc50d930b1ad2670. However, I didn't move the following 4 setters: ```HasMaxIter.setMaxIter``` ```HasSeed.setSeed``` ```HasCheckpointInterval.setCheckpointInterval``` ```HasStepSize.setStepSize``` The reason that I didn't change these 4 setters is because besides ```DecisionTreeClassifier/Regressor```, ```GBTClassifier/Regressor```, ```RandomForestClassifier/Regressor``` (these are the files that changed in https://github.com/apache/spark/commit/4aa9ccbde7870fb2750712e9e38e6aad740e0770#diff-6b8a041f558af2b7bc50d930b1ad2670), quite a few other classes in PySpark also implement these ```HasXXX```, for example, ```LogisticRegression```, ```GaussianMixture```, ```KMeans```, ```LDA```, etc. also implement ```HasMaxIter``` and rely on its ```setMaxIter```. So I guess I will leave ```HasMaxIter.setMaxIter``` and the other 3 setters as is.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
