huaxingao commented on issue #25046: [SPARK-28243][PYSPARK][ML] Remove setFeatureSubsetStrategy and setSubsamplingRate from Python TreeEnsembleParams URL: https://github.com/apache/spark/pull/25046#issuecomment-512519211 I initially did this https://github.com/apache/spark/pull/21413 so I know I marked this ```TreeEnsembleParams.setFeatureSubsetStrategy``` deprecated and need to remove it later on. When I removed it I saw ```setSubsamplingRate``` and removed it too. I will also move all the other deprecated setters in https://github.com/apache/spark/commit/4aa9ccbde7870fb2750712e9e38e6aad740e0770#diff-6b8a041f558af2b7bc50d930b1ad2670 too. Do you prefer me to do it in this PR or have a separate PR? @srowen
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
