vanzin commented on a change in pull request #24879: [SPARK-28042][K8S] Support 
using volume mount as local storage
URL: https://github.com/apache/spark/pull/24879#discussion_r306920189
 
 

 ##########
 File path: docs/running-on-kubernetes.md
 ##########
 @@ -285,7 +285,16 @@ The configuration properties for mounting volumes into 
the executor pods use pre
 
 ## Local Storage
 
-Spark uses temporary scratch space to spill data to disk during shuffles and 
other operations.  When using Kubernetes as the resource manager the pods will 
be created with an 
[emptyDir](https://kubernetes.io/docs/concepts/storage/volumes/#emptydir) 
volume mounted for each directory listed in `SPARK_LOCAL_DIRS`.  If no 
directories are explicitly specified then a default directory is created and 
configured appropriately.
+Spark supports using volumes to spill data during shuffles and other 
operations. To use a volume as local storage, the volume's name should starts 
with `spark-local-dir-` and the mount path should be set in the spark 
configuration `spark.local.dir` or in the pod environment variable 
`SPARK_LOCAL_DIRS`, for example:
 
 Review comment:
   Why do you need both setting the volume name and the config value?
   
   You can just build the configuration from the list of volumes that match the 
expected name.
   
   If an explicit configuration is set, you should keep the previous behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to