vanzin commented on a change in pull request #24879: [SPARK-28042][K8S] Support
using volume mount as local storage
URL: https://github.com/apache/spark/pull/24879#discussion_r307398714
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala
##########
@@ -40,24 +41,33 @@ private[spark] class LocalDirsFeatureStep(
private val useLocalDirTmpFs = conf.get(KUBERNETES_LOCAL_DIRS_TMPFS)
override def configurePod(pod: SparkPod): SparkPod = {
- val localDirVolumes = resolvedLocalDirs
- .zipWithIndex
- .map { case (localDir, index) =>
- new VolumeBuilder()
- .withName(s"spark-local-dir-${index + 1}")
- .withNewEmptyDir()
- .withMedium(if (useLocalDirTmpFs) "Memory" else null)
- .endEmptyDir()
- .build()
- }
- val localDirVolumeMounts = localDirVolumes
- .zip(resolvedLocalDirs)
- .map { case (localDirVolume, localDirPath) =>
- new VolumeMountBuilder()
- .withName(localDirVolume.getName)
- .withMountPath(localDirPath)
- .build()
- }
+ var localDirs = findLocalDirVolumeMount(pod)
+ var localDirVolumes : Seq[Volume] = Seq()
+ var localDirVolumeMounts : Seq[VolumeMount] = Seq()
+
+ if (localDirs.isEmpty) {
+ localDirs = resolvedLocalDirs.toSeq
Review comment:
Get rid of `resolvedLocalDirs` and move that statement here instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
