vanzin commented on a change in pull request #24879: [SPARK-28042][K8S] Support
using volume mount as local storage
URL: https://github.com/apache/spark/pull/24879#discussion_r307396733
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
##########
@@ -43,12 +43,12 @@ private[spark] class KubernetesDriverBuilder {
new DriverServiceFeatureStep(conf),
new MountSecretsFeatureStep(conf),
new EnvSecretsFeatureStep(conf),
- new LocalDirsFeatureStep(conf),
new MountVolumesFeatureStep(conf),
new DriverCommandFeatureStep(conf),
new HadoopConfDriverFeatureStep(conf),
new KerberosConfDriverFeatureStep(conf),
- new PodTemplateConfigMapStep(conf))
+ new PodTemplateConfigMapStep(conf),
+ new LocalDirsFeatureStep(conf))
Review comment:
Either is fine, just wanted to point out that the pod template is
initialized before any step is executed (i.e. `PodTemplateConfigMapStep` is not
where the template is loaded).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
