dongjoon-hyun commented on a change in pull request #25220: [SPARK-28459][SQL] Add `make_timestamp` function URL: https://github.com/apache/spark/pull/25220#discussion_r308008225
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ########## @@ -1657,3 +1657,146 @@ case class MakeDate(year: Expression, month: Expression, day: Expression) override def prettyName: String = "make_date" } + +// scalastyle:off line.size.limit +@ExpressionDescription( + usage = "_FUNC_(year, month, day, hour, min, sec, timezone) - Create timestamp from year, month, day, hour, min, sec and timezone fields.", + arguments = """ + Arguments: + * year - the year to represent, from 1 to 9999 + * month - the month-of-year to represent, from 1 (January) to 12 (December) + * day - the day-of-month to represent, from 1 to 31 + * hour - the hour-of-day to represent, from 0 to 23 + * minute - the minute-of-hour to represent, from 0 to 59 Review comment: `min`? Argument should be matched with line 1663. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
