dongjoon-hyun commented on a change in pull request #25220: [SPARK-28459][SQL] Add `make_timestamp` function URL: https://github.com/apache/spark/pull/25220#discussion_r308008399
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ########## @@ -1657,3 +1657,146 @@ case class MakeDate(year: Expression, month: Expression, day: Expression) override def prettyName: String = "make_date" } + +// scalastyle:off line.size.limit +@ExpressionDescription( + usage = "_FUNC_(year, month, day, hour, min, sec, timezone) - Create timestamp from year, month, day, hour, min, sec and timezone fields.", + arguments = """ + Arguments: + * year - the year to represent, from 1 to 9999 + * month - the month-of-year to represent, from 1 (January) to 12 (December) + * day - the day-of-month to represent, from 1 to 31 + * hour - the hour-of-day to represent, from 0 to 23 + * minute - the minute-of-hour to represent, from 0 to 59 + * second - the second-of-minute and its micro-fraction to represent, from + 0 to 60. If the second argument equals to 60, the seconds field is set + to 0 and 1 minute is added to the final timestamp. + * timezone - optional time zone identifier. For example, CET, UTC and etc. + """, + examples = """ + Examples: + > SELECT _FUNC_(2014, 12, 28, 6, 30, 45.887); + 2014-12-28 06:30:45.887 + > SELECT _FUNC_(2014, 12, 28, 6, 30, 45.887, 'CET'); + 2014-12-28 10:30:45.887 + > SELECT _FUNC_(2019, 6, 30, 23, 59, 60.5) + 2019-07-01 00:00:00.5 Review comment: Thank you for adding this. However, this is incompatible with PrestoSQL. We should only accept 60. `60.5` is out of the range. ``` postgres=# select make_timestamp(2019, 6, 30, 23, 59, 60.5); ERROR: time field value out of range: 23:59:60.5 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
